From 1ba03ab6fdd0dcb1193480eeac21948fa61232df Mon Sep 17 00:00:00 2001 From: Darkelarious Date: Sun, 1 Oct 2017 12:36:47 +0200 Subject: fixed undefined variable use when unsupported games respond with incomplete status query --- lib/MasterServer/Core/Logging.pm | 2 +- lib/MasterServer/Core/Version.pm | 4 ++-- lib/MasterServer/UDP/DatagramProcessor.pm | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/MasterServer/Core/Logging.pm b/lib/MasterServer/Core/Logging.pm index 260b379..41e0324 100755 --- a/lib/MasterServer/Core/Logging.pm +++ b/lib/MasterServer/Core/Logging.pm @@ -63,7 +63,7 @@ sub log { $SIG{__WARN__} = undef; chomp $msg; - $msg =~ s/\n/\n | /g; + $msg =~ s/\n/ /g; if($logfile && open my $F, '>>:utf8', $logfile) { flock $F, 2; seek $F, 0, 2; diff --git a/lib/MasterServer/Core/Version.pm b/lib/MasterServer/Core/Version.pm index 277cd04..96b0a3b 100755 --- a/lib/MasterServer/Core/Version.pm +++ b/lib/MasterServer/Core/Version.pm @@ -27,13 +27,13 @@ sub version { $self->{build_type} = "333networks Masterserver-Perl Multidb"; # version - $self->{build_version} = "2.4.1"; + $self->{build_version} = "2.4.2"; # short version for uplinks $self->{short_version} = "MS-perl $self->{build_version}"; # date yyyy-mm-dd - $self->{build_date} = "2017-09-25"; + $self->{build_date} = "2017-09-30"; #author, email $self->{build_author} = "Darkelarious, darkelarious\@333networks.com"; diff --git a/lib/MasterServer/UDP/DatagramProcessor.pm b/lib/MasterServer/UDP/DatagramProcessor.pm index 87c23a1..99ced03 100755 --- a/lib/MasterServer/UDP/DatagramProcessor.pm +++ b/lib/MasterServer/UDP/DatagramProcessor.pm @@ -14,7 +14,7 @@ sub process_datagram { my $rx = $self->data2hashref($o{rxbuf}); # can not proceed if validate was provided, but not gamename - return 0 if ( $rx->{validate} && not($rx->{gamename}) ); + return 0 unless $rx->{gamename}; # do not process data if no hostport was provided. return 0 unless $rx->{hostport}; -- cgit v1.2.3